-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix db downgrade check condition #52982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Does it warrant rc5 @kaxil ? |
Yes, there is another bug that @pierrejeambrun has found |
Ok. I was just about to run the verification :D.. Will wait. |
74cf526 to
fe3e383
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took us a bit to find the real culprit - thanks past Jed!
ephraimbuddy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it should be 2.10.3 since we have 2.11.0
ephraimbuddy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. No migration for 2.11.0
* fix rollback from airflow3 * use fab for test * amend * fix test * revert condition fix and add shortcut if revisions are same * updating revision to 2.10.3 in condition * remove fab from tests (cherry picked from commit d458554) Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
* fix rollback from airflow3 * use fab for test * amend * fix test * revert condition fix and add shortcut if revisions are same * updating revision to 2.10.3 in condition * remove fab from tests (cherry picked from commit d458554) Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
* fix rollback from airflow3 * use fab for test * amend * fix test * revert condition fix and add shortcut if revisions are same * updating revision to 2.10.3 in condition * remove fab from tests (cherry picked from commit d458554) Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
* fix rollback from airflow3 * use fab for test * amend * fix test * revert condition fix and add shortcut if revisions are same * updating revision to 2.10.3 in condition * remove fab from tests
* fix rollback from airflow3 * use fab for test * amend * fix test * revert condition fix and add shortcut if revisions are same * updating revision to 2.10.3 in condition * remove fab from tests
This PR fixes an issue where downgrading from 3.0.3rc4 to 3.0.2 was failing
The current downgrade logic treats downgrading to 3.0.0 the same as downgrading below 3.0.0, which is incorrect.
ERROR
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.