Bring back quick image build check and increase timeout minutes #53227
Conversation
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
Good point - I think it does somehow (it did work so far). But we can remove the whole step here - it's not needed at all |
The apache#53212 changed the quick-image-build check to only run on canary build, but this was not the intention - and the image started to fail because of timeout minutes were too short after we added python building from sources. This PR fixes it "properly" - changes timeout minutes to be slightly longer than the timeout (900 seconds) we specify in build command and brings back building the image on regular PRs.
potiuk
force-pushed
the
fix-timeout-minutes-on-quick-image-build
branch
from
94aed4a to
de4852d
Compare
cool was chnaged it because thought it needs docker login :) |
|
Yep.. It somehow worked in the PR that failed and triggered #53212 
|
|
But I removed it now.. The "build" only builds local image it does not try to push it, it only makes sure it takes less than <900 seconds - so we don't even need to log-in to docker |
|
But ... it might also hit rate limits. Maybe we will have to bring it back - let's see. I believe anything coming from GitHub CI to docker has higher rate limits by default as far as I remember. |
|
Thanks for the change! |
…inutes (#53227) The #53212 changed the quick-image-build check to only run on canary build, but this was not the intention - and the image started to fail because of timeout minutes were too short after we added python building from sources. This PR fixes it "properly" - changes timeout minutes to be slightly longer than the timeout (900 seconds) we specify in build command and brings back building the image on regular PRs. (cherry picked from commit 5579edd) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Backport successfully created: v3-0-test
|
…inutes (#53227) (#53230) The #53212 changed the quick-image-build check to only run on canary build, but this was not the intention - and the image started to fail because of timeout minutes were too short after we added python building from sources. This PR fixes it "properly" - changes timeout minutes to be slightly longer than the timeout (900 seconds) we specify in build command and brings back building the image on regular PRs. (cherry picked from commit 5579edd) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
…he#53227) The apache#53212 changed the quick-image-build check to only run on canary build, but this was not the intention - and the image started to fail because of timeout minutes were too short after we added python building from sources. This PR fixes it "properly" - changes timeout minutes to be slightly longer than the timeout (900 seconds) we specify in build command and brings back building the image on regular PRs.
5 participants
The #53212 changed the quick-image-build check to only run on canary build, but this was not the intention - and the image started to fail because of timeout minutes were too short after we added python building from sources.
This PR fixes it "properly" - changes timeout minutes to be slightly longer than the timeout (900 seconds) we specify in build command and brings back building the image on regular PRs.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.