Skip to content

Cleanup type ignores in vertica provider where possible #53252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gopidesupavan merged 2 commits into from
Jul 13, 2025
Merged

Cleanup type ignores in vertica provider where possible #53252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de0c217
Cleanup type ignores in vertica provider where possible
jscheffl Jul 12, 2025
28ee4f9
Get the hook the right way via get_conn_id()
jscheffl Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions providers/vertica/src/airflow/providers/vertica/hooks/vertica.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class VerticaHook(DbApiHook):

def get_conn(self) -> connect:
"""Return vertica connection object."""
conn = self.get_connection(self.vertica_conn_id) # type: ignore
conn = self.get_connection(self.get_conn_id())
conn_config: dict[str, Any] = {
"user": conn.login,
"password": conn.password or "",
Expand Down Expand Up @@ -134,7 +134,7 @@ def get_conn(self) -> connect:
conn = connect(**conn_config)
return conn

@overload # type: ignore[override]
@overload
def run(
self,
sql: str | Iterable[str],
Expand Down