Skip to content

Cleanup mypy ignores in databricks provider where possible #53265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gopidesupavan merged 1 commit into from
Jul 12, 2025
Merged

Cleanup mypy ignores in databricks provider where possible #53265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions providers/databricks/src/airflow/providers/databricks/hooks/databricks_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
overload,
)

from databricks import sql # type: ignore[attr-defined]
from databricks import sql
from databricks.sql.types import Row

from airflow.exceptions import AirflowException
Expand Down Expand Up @@ -173,7 +173,7 @@ def get_conn(self) -> AirflowConnection:
raise AirflowException("SQL connection is not initialized")
return cast("AirflowConnection", self._sql_conn)

@overload # type: ignore[override]
@overload
def run(
self,
sql: str | Iterable[str],
Expand Down Expand Up @@ -258,7 +258,7 @@ def run(

# TODO: adjust this to make testing easier
try:
self._run_command(cur, sql_statement, parameters) # type: ignore[attr-defined]
self._run_command(cur, sql_statement, parameters)
except Exception as e:
if t is None or t.is_alive():
raise DatabricksSqlExecutionError(
Expand Down
6 changes: 2 additions & 4 deletions providers/databricks/src/airflow/providers/databricks/operators/databricks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
from airflow.sdk import BaseOperatorLink
from airflow.sdk.execution_time.xcom import XCom
else:
from airflow.models import XCom # type: ignore[no-redef]
from airflow.models import XCom
from airflow.models.baseoperatorlink import BaseOperatorLink # type: ignore[no-redef]

DEFER_METHOD_NAME = "execute_complete"
Expand Down Expand Up @@ -1428,9 +1428,7 @@ def execute(self, context: Context) -> None:
if not self.workflow_run_metadata:
launch_task_id = next(task for task in self.upstream_task_ids if task.endswith(".launch"))
self.workflow_run_metadata = context["ti"].xcom_pull(task_ids=launch_task_id)
workflow_run_metadata = WorkflowRunMetadata( # type: ignore[arg-type]
**self.workflow_run_metadata
)
workflow_run_metadata = WorkflowRunMetadata(**self.workflow_run_metadata)
self.databricks_run_id = workflow_run_metadata.run_id
self.databricks_conn_id = workflow_run_metadata.conn_id

Expand Down
2 changes: 1 addition & 1 deletion providers/databricks/src/airflow/providers/databricks/plugins/databricks_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
from airflow.sdk import BaseOperatorLink
from airflow.sdk.execution_time.xcom import XCom
else:
from airflow.models import XCom # type: ignore[no-redef]
from airflow.models import XCom
from airflow.models.baseoperatorlink import BaseOperatorLink # type: ignore[no-redef]


Expand Down
4 changes: 2 additions & 2 deletions providers/databricks/src/airflow/providers/databricks/utils/openlineage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,8 @@ def emit_openlineage_events_for_databricks_queries(
event_batch = _create_ol_event_pair(
job_namespace=namespace(),
job_name=f"{task_instance.dag_id}.{task_instance.task_id}.query.{counter}",
start_time=query_metadata.get("start_time") or default_event_time, # type: ignore[arg-type]
end_time=query_metadata.get("end_time") or default_event_time, # type: ignore[arg-type]
start_time=query_metadata.get("start_time") or default_event_time,
end_time=query_metadata.get("end_time") or default_event_time,
# Only finished status means it completed without failures
is_successful=(query_metadata.get("status") or default_state).lower() == "finished",
run_facets={**query_specific_run_facets, **common_run_facets, **additional_run_facets},
Expand Down