Skip to content

Cleanup type ignores in papermill provider where possible #53279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jscheffl merged 1 commit into from
Jul 12, 2025
Merged

Cleanup type ignores in papermill provider where possible #53279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions providers/papermill/src/airflow/providers/papermill/operators/papermill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
from airflow.sdk.definitions.context import Context
except ImportError:
# TODO: Remove once provider drops support for Airflow 2
from airflow.utils.context import Context # type: ignore[no-redef]
from airflow.utils.context import Context


@attr.s(auto_attribs=True)
Expand Down Expand Up @@ -106,9 +106,9 @@ def __init__(

def execute(self, context: Context):
if not isinstance(self.input_nb, NoteBook):
self.input_nb = NoteBook(url=self.input_nb, parameters=self.parameters) # type: ignore[call-arg]
self.input_nb = NoteBook(url=self.input_nb, parameters=self.parameters)
if not isinstance(self.output_nb, NoteBook):
self.output_nb = NoteBook(url=self.output_nb) # type: ignore[call-arg]
self.output_nb = NoteBook(url=self.output_nb)
if not AIRFLOW_V_3_0_PLUS:
self.inlets.append(self.input_nb)
self.outlets.append(self.output_nb)
Expand Down
2 changes: 1 addition & 1 deletion providers/papermill/src/airflow/providers/papermill/version_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def get_base_airflow_version_tuple() -> tuple[int, int, int]:
if AIRFLOW_V_3_0_PLUS:
from airflow.sdk import BaseOperator
else:
from airflow.models import BaseOperator # type: ignore[no-redef]
from airflow.models import BaseOperator

if AIRFLOW_V_3_1_PLUS:
from airflow.sdk import BaseHook
Expand Down