Skip to content

Cleanup type ignores in common/sql provider #53297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jul 13, 2025
Merged

Cleanup type ignores in common/sql provider #53297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/common/sql/src/airflow/providers/common/sql/operators/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1247,7 +1247,7 @@ def execute(self, context: Context):
)

# TODO(potiuk) remove the type ignore once we solve provider <-> Task SDK relationship
self.skip_all_except(context["ti"], follow_branch) # type: ignore[arg-type]
self.skip_all_except(context["ti"], follow_branch)


def _initialize_partition_clause(clause: str | None) -> str | None:
Expand Down
4 changes: 2 additions & 2 deletions providers/common/sql/tests/unit/common/sql/sensors/test_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ def test_sql_sensor_postgres_poke_invalid_failure(self, mock_hook):
task_id="sql_sensor_check",
conn_id="postgres_default",
sql="SELECT 1",
failure=[1], # type: ignore[arg-type]
failure=[1],
)

mock_hook.get_connection.return_value.get_hook.return_value = mock.MagicMock(spec=DbApiHook)
Expand All @@ -246,7 +246,7 @@ def test_sql_sensor_postgres_poke_invalid_success(
task_id="sql_sensor_check",
conn_id="postgres_default",
sql="SELECT 1",
success=[1], # type: ignore[arg-type]
success=[1],
)

mock_hook.get_connection.return_value.get_hook.return_value = mock.MagicMock(spec=DbApiHook)
Expand Down