Skip to content

auto-sync change of TaskInstance note without manual refresh #53307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierrejeambrun merged 1 commit into from
Aug 1, 2025
Merged

auto-sync change of TaskInstance note without manual refresh #53307

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion airflow-core/src/airflow/ui/src/components/EditableMarkdownButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const EditableMarkdownButton = ({
isPending,
mdContent,
onConfirm,
onOpen,
placeholder,
setMdContent,
text,
Expand All @@ -41,6 +42,7 @@ const EditableMarkdownButton = ({
readonly isPending: boolean;
readonly mdContent?: string | null;
readonly onConfirm: () => void;
readonly onOpen: () => void;
readonly placeholder: string;
readonly setMdContent: (value: string) => void;
readonly text: string;
Expand All @@ -54,7 +56,12 @@ const EditableMarkdownButton = ({
<ActionButton
actionName={placeholder}
icon={icon}
onClick={() => setIsOpen(true)}
onClick={() => {
if (!isOpen) {
onOpen();
}
setIsOpen(true);
}}
text={text}
withText={withText}
/>
Expand All @@ -64,6 +71,7 @@ const EditableMarkdownButton = ({
onOpenChange={() => setIsOpen(false)}
open={isOpen}
size="md"
unmountOnExit={true}
>
<Dialog.Content backdrop>
<Dialog.Header bg="blue.muted">
Expand Down
6 changes: 6 additions & 0 deletions airflow-core/src/airflow/ui/src/pages/Run/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ export const Header = ({
});
}
}, [dagId, dagRun.note, dagRunId, mutate, note]);

const onOpen = () => {
setNote(dagRun.note ?? "");
};

const containerRef = useRef<HTMLDivElement>();
const containerWidth = useContainerWidth(containerRef);

Expand All @@ -74,6 +79,7 @@ export const Header = ({
isPending={isPending}
mdContent={note}
onConfirm={onConfirm}
onOpen={onOpen}
placeholder={translate("note.placeholder")}
setMdContent={setNote}
text={Boolean(dagRun.note) ? translate("note.label") : translate("note.add")}
Expand Down
5 changes: 5 additions & 0 deletions airflow-core/src/airflow/ui/src/pages/TaskInstance/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ export const Header = ({
}
}, [dagId, dagRunId, mapIndex, mutate, note, taskId, taskInstance.note]);

const onOpen = () => {
setNote(taskInstance.note ?? "");
};

return (
<Box ref={containerRef}>
<HeaderCard
Expand All @@ -99,6 +103,7 @@ export const Header = ({
isPending={isPending}
mdContent={note}
onConfirm={onConfirm}
onOpen={onOpen}
placeholder={translate("note.placeholder")}
setMdContent={setNote}
text={Boolean(taskInstance.note) ? translate("note.label") : translate("note.add")}
Expand Down