Skip to content

Cleanup mypy ignore in standard provider where possible #53308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gopidesupavan merged 1 commit into from
Jul 13, 2025
Merged

Cleanup mypy ignore in standard provider where possible #53308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/standard/src/airflow/providers/standard/operators/branch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
if AIRFLOW_V_3_0_PLUS:
from airflow.providers.standard.utils.skipmixin import SkipMixin
else:
from airflow.models.skipmixin import SkipMixin # type: ignore[no-redef]
from airflow.models.skipmixin import SkipMixin

if TYPE_CHECKING:
from airflow.sdk.definitions.context import Context
Expand Down
4 changes: 2 additions & 2 deletions providers/standard/src/airflow/providers/standard/operators/python.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
from airflow.providers.standard.operators.branch import BaseBranchOperator
from airflow.providers.standard.utils.skipmixin import SkipMixin
else:
from airflow.models.skipmixin import SkipMixin # type: ignore[no-redef]
from airflow.models.skipmixin import SkipMixin
from airflow.operators.branch import BaseBranchOperator # type: ignore[no-redef]


Expand Down Expand Up @@ -330,7 +330,7 @@ def get_tasks_to_skip():
self.skip(
dag_run=context["dag_run"],
tasks=to_skip,
execution_date=cast("DateTime", dag_run.logical_date), # type: ignore[call-arg, union-attr]
execution_date=cast("DateTime", dag_run.logical_date), # type: ignore[call-arg]
map_index=context["ti"].map_index,
)

Expand Down
2 changes: 1 addition & 1 deletion providers/standard/src/airflow/providers/standard/operators/trigger_dagrun.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
if AIRFLOW_V_3_0_PLUS:
from airflow.sdk.execution_time.xcom import XCom
else:
from airflow.models import XCom # type: ignore[no-redef]
from airflow.models import XCom


class DagIsPaused(AirflowException):
Expand Down
2 changes: 1 addition & 1 deletion providers/standard/src/airflow/providers/standard/sensors/external_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
if AIRFLOW_V_3_0_PLUS:
from airflow.sdk.definitions.context import Context
else:
from airflow.utils.context import Context # type: ignore[no-redef]
from airflow.utils.context import Context


class ExternalDagLink(BaseOperatorLink):
Expand Down
6 changes: 3 additions & 3 deletions providers/standard/src/airflow/providers/standard/triggers/external_task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ async def run(self) -> typing.AsyncIterator[TriggerEvent]:
return
allowed_count = await get_count_func(self.allowed_states)

if allowed_count == len(run_id_or_dates): # type: ignore[arg-type]
if allowed_count == len(run_id_or_dates):
yield TriggerEvent({"status": "success"})
return
self.log.info("Sleeping for %s seconds", self.poke_interval)
Expand All @@ -140,7 +140,7 @@ async def _get_count_af_3(self, states):
}
if self.external_task_ids:
count = await sync_to_async(RuntimeTaskInstance.get_ti_count)(
task_ids=self.external_task_ids, # type: ignore[arg-type]
task_ids=self.external_task_ids,
states=states,
**params,
)
Expand Down Expand Up @@ -233,7 +233,7 @@ async def run(self) -> typing.AsyncIterator[TriggerEvent]:
return
else:
while True:
num_dags = await self.count_dags() # type: ignore[call-arg]
num_dags = await self.count_dags()
if num_dags == runs_ids_or_dates:
yield TriggerEvent(self.serialize())
return
Expand Down
2 changes: 1 addition & 1 deletion providers/standard/src/airflow/providers/standard/utils/skipmixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def _ensure_tasks(nodes: Iterable[DAGNode]) -> Sequence[Operator]:
from airflow.sdk.definitions.mappedoperator import MappedOperator
else:
from airflow.models.baseoperator import BaseOperator # type: ignore[no-redef]
from airflow.models.mappedoperator import MappedOperator # type: ignore[no-redef]
from airflow.models.mappedoperator import MappedOperator

return [n for n in nodes if isinstance(n, (BaseOperator, MappedOperator))]

Expand Down
2 changes: 1 addition & 1 deletion providers/standard/tests/unit/standard/sensors/test_python.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@

class TestPythonSensor(BasePythonTest):
# TODO(kaxil) - this typing hint is fishy
opcls = PythonSensor # type: ignore[assignment]
opcls = PythonSensor

def test_python_sensor_true(self):
self.run_as_task(fn=lambda: True)
Expand Down