Skip to content

Clean up mypy ignores in drill provider #53320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 1 commit into from
Jul 13, 2025
Merged

Clean up mypy ignores in drill provider #53320

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions providers/apache/drill/src/airflow/providers/apache/drill/hooks/drill.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
from __future__ import annotations

from collections.abc import Iterable
from typing import TYPE_CHECKING, Any
from typing import TYPE_CHECKING, Any, NoReturn

from sqlalchemy import create_engine

Expand Down Expand Up @@ -83,9 +83,7 @@ def get_uri(self) -> str:

# The superclass DbApiHook's method implementation has a return type `None` and mypy fails saying
# return type `NotImplementedError` is incompatible with it. Hence, we ignore the mypy error here.
def set_autocommit( # type: ignore[override]
self, conn: Connection, autocommit: bool
) -> NotImplementedError:
def set_autocommit(self, conn: Connection, autocommit: bool) -> NoReturn:
raise NotImplementedError("There are no transactions in Drill.")

# The superclass DbApiHook's method implementation has a return type `None` and mypy fails saying
Expand Down