Refactor google.cloud imports to prevent conflicts with airflow google provider namespace and resolve mypy errors #53338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…namespace and resolve mypy errors
boring-cyborg
bot
added
area:logging
area:providers
provider:google
gopidesupavan
requested review from
amoghrajesh,
ashb,
eladkal,
jscheffl,
kaxil and
potiuk
gopidesupavan
changed the title
kaxil
approved these changes
Jul 14, 2025
…namespace and resolve mypy errors
gopidesupavan
force-pushed
the
update-imports-gcs
branch
from
c050266 to
e177ca0
Compare
Member
|
Nice! |
prdai
pushed a commit
to prdai/airflow
that referenced
this pull request
Jul 15, 2025
…e provider namespace and resolve mypy errors (apache#53338) * Refactor google.cloud imports to prevent conflicts with local google namespace and resolve mypy errors * Refactor google.cloud imports to prevent conflicts with local google namespace and resolve mypy errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like mypy is treating modual path
storageis not available in google name space, its because the in provider google namespace we have goog.cloud and gcs package also has google.cloud.Its better to import with full path from google-cloud-storage package.Updated with alias.
This also helps idea's to discover better, right now idea's showing this storage path not available.
After updating imports tested , nothing breaks.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.