Remove support for re-serializing a serialized op #53340
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should theoratically no longer be needed. I think there's another test somewhere... the CI will tell.
Contributor
|
Is maintaining the support problematic? If i were going to remove support, i would make it fail when it is attempted. Because otherwise it turns into string and that's just recipe for confusion and delayed error resolution. |
Member
Author
|
Yeah the problem is it seems like we’re unintentionally using this feature anyway (otherwise the tests wouldn’t be failing) so this can’t be removed unless we fix that first anyway. |
Member
Author
|
Let’s not bother for now. We can revisit this (a lot) later. |
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jul 23, 2025
Bringing apache#53340 back but only for removing Reserialized BaseOp.
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Aug 12, 2025
Bringing apache#53340 back but only for removing Reserialized BaseOp.
kaxil
added a commit
that referenced
this pull request
Aug 12, 2025
Bringing #53340 back but only for removing Reserialized BaseOp.
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Aug 12, 2025
Bringing apache#53340 back but only for removing Reserialized BaseOp.
potiuk
pushed a commit
that referenced
this pull request
Aug 13, 2025
Bringing #53340 back but only for removing Reserialized BaseOp.
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 24, 2025
Bringing apache/airflow#53340 back but only for removing Reserialized BaseOp. GitOrigin-RevId: 5a4b4904b00c23cdddf662c33be31796f541056d
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 24, 2025
Bringing apache/airflow#53340 back but only for removing Reserialized BaseOp. GitOrigin-RevId: 3e82aad6adea06b51301fcd08a2787e500a65d9b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should theoratically no longer be needed. I think there's another test somewhere... the CI will tell.