Skip to content

Conversation

@m-rossi
Copy link
Contributor

@m-rossi m-rossi commented Jul 16, 2025

closes: #49920

This PR tries to fix the issue #49920, the SmtpHook is tried to be used and its properties are only available once the .conn attibute is available, which is only the case in the with statement.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@m-rossi m-rossi requested a review from hussein-awala as a code owner July 16, 2025 12:48
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 16, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@shahar1
Copy link
Contributor

shahar1 commented Jul 19, 2025

Welcome to Apache Airflow and thanks for your contribution!
I hope you could figure out #49920 as well :)

@shahar1 shahar1 merged commit 50f6222 into apache:main Jul 19, 2025
3 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 19, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

airflow.exceptions.AirflowException: The smtp connection should be loaded before!

2 participants