Skip to content

[v3-0-test] Add --warn-unreachable flag to mypy as a optional flag (#53398) #53428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions wants to merge 1 commit into from
Closed

[v3-0-test] Add --warn-unreachable flag to mypy as a optional flag (#53398) #53428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions scripts/ci/pre_commit/mypy_folder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
mypy_folders = sys.argv[1:]

show_unused_warnings = os.environ.get("SHOW_UNUSED_MYPY_WARNINGS", "false")
show_unreachable_warnings = os.environ.get("SHOW_UNREACHABLE_MYPY_WARNINGS", "false")

for mypy_folder in mypy_folders:
if mypy_folder not in ALLOWED_FOLDERS:
Expand Down Expand Up @@ -127,14 +128,21 @@ def get_all_files(folder: str) -> list[str]:

print(f"Running mypy with {FILE_ARGUMENT}")

mypy_cmd_parts = [f"TERM=ansi mypy {shlex.quote(FILE_ARGUMENT)}"]

if show_unused_warnings == "true":
console.print(
"[info]Running mypy with --warn-unused-ignores to display unused ignores, unset environment variable: SHOW_UNUSED_MYPY_WARNINGS to runoff this behaviour"
)
mypy_cmd_parts.append("--warn-unused-ignores")

mypy_cmd = f"TERM=ansi mypy {shlex.quote(FILE_ARGUMENT)} --warn-unused-ignores"
else:
mypy_cmd = f"TERM=ansi mypy {shlex.quote(FILE_ARGUMENT)}"
if show_unreachable_warnings == "true":
console.print(
"[info]Running mypy with --warn-unreachable to display unreachable code, unset environment variable: SHOW_UNREACHABLE_MYPY_WARNINGS to runoff this behaviour"
)
mypy_cmd_parts.append("--warn-unreachable")

mypy_cmd = " ".join(mypy_cmd_parts)

cmd = ["bash", "-c", mypy_cmd]

Expand Down