Fix unreachable code mypy warnings in standard provider #53431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
commented
Jul 16, 2025
jscheffl
commented
Jul 16, 2025
jscheffl
commented
Jul 16, 2025
providers/standard/src/airflow/providers/standard/utils/python_virtualenv.py
Show resolved
Hide resolved
jscheffl
commented
Jul 16, 2025
providers/standard/src/airflow/providers/standard/utils/python_virtualenv.py
Show resolved
Hide resolved
jscheffl
force-pushed
the
bugfix/remove-or-fix-unreachable-code-in-standard-provider
branch
from
5f37928 to
7cd942c
Compare
Contributor
Author
|
Request another review. Any expert around? |
jscheffl
requested review from
amoghrajesh,
ashb,
dstandish,
kaxil,
potiuk and
vincbeck
kaxil
reviewed
Jul 18, 2025
providers/standard/tests/unit/standard/operators/test_python.py
Outdated
Show resolved
Hide resolved
jscheffl
force-pushed
the
bugfix/remove-or-fix-unreachable-code-in-standard-provider
branch
from
7cb6463 to
de3a5f6
Compare
kaxil
approved these changes
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #53395
As this is a very code provider I would request two reviews before merge. Also some rationale for the changes are in comments (they are for rationale and not to block review)