-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add type ignore unreachable for get_autocommit in jdbc provider #53434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type ignore unreachable for get_autocommit in jdbc provider #53434
Conversation
|
after checking |
|
As for the future---- I still I would consider a PR makes sense to (1) add a type:ignore to suppress the warnign and (2) also add a comment why this is needed -for the future you/me that wants to fix the code. Can you also tell me how the code is executed that the first return is not hit? Will then a driver raise an exception which is catched and then the second return is kicking-in? |
yeah will reopen this update type ignore. we have this custom suppression logic |
|
an example it simulates that behaviours |
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
related #53395
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.