Skip to content

Fix FAB provider in unreachable code #53436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gopidesupavan merged 1 commit into from
Jul 17, 2025
Merged

Fix FAB provider in unreachable code #53436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions providers/fab/src/airflow/providers/fab/auth_manager/security_manager/override.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1551,15 +1551,15 @@ def delete_action(self, name: str) -> bool:
---------------
"""

def get_resource(self, name: str) -> Resource:
def get_resource(self, name: str) -> Resource | None:
"""
Return a resource record by name, if it exists.

:param name: Name of resource
"""
return self.get_session.query(self.resource_model).filter_by(name=name).one_or_none()

def create_resource(self, name) -> Resource:
def create_resource(self, name) -> Resource | None:
"""
Create a resource with the given name.

Expand Down Expand Up @@ -1628,6 +1628,9 @@ def create_permission(self, action_name, resource_name) -> Permission | None:
if perm:
return perm
resource = self.create_resource(resource_name)
if resource is None:
log.error(const.LOGMSG_ERR_SEC_ADD_PERMVIEW, f"Resource creation failed {resource_name}")
return None
action = self.create_action(action_name)
perm = self.permission_model()
perm.resource_id, perm.action_id = resource.id, action.id
Expand Down