Skip to content

Conversation

@BobDu
Copy link
Contributor

@BobDu BobDu commented Jul 17, 2025

  1. Fix wait_for_completion parameter documentation - Remove references to deleted parameters in docstring

  2. Fix example file parameter references - Correct usage of removed parameters in example code

  3. Minor parameter documentation improvements - Enhance default value descriptions for consistency


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

- Correct parameter names (waiter_check_interval_seconds -> waiter_delay)
- Improve English grammar and wording in docstrings
- Standardize parameter documentation format
- Fix default value descriptions to match actual code

Signed-off-by: BobDu <i@bobdu.cc>
@BobDu BobDu requested review from eladkal and o-nikolas as code owners July 17, 2025 09:55
@boring-cyborg boring-cyborg bot added area:providers provider:amazon AWS/Amazon - related issues labels Jul 17, 2025
Copy link
Contributor

@dominikhei dominikhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a duplicate wait_for_completion param in line 91 & 94 in the docstrings of the EmrAddStepsOperator. Whilst you are add it you might fix that as well :)

…epsOperator

Signed-off-by: BobDu <i@bobdu.cc>
Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@vincbeck vincbeck merged commit 46cccf9 into apache:main Jul 17, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants