Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jul 17, 2025

When running "update-installers-and-pre-commit" pre-commit, the script is virtually guaranteed to fail with "rate limits" reached if you do not use GITHUB_TOKEN. This change makes GITHUB_TOKEN variable mandatory for the pre-commit, it prints the helpful information and prints URL that allows to create such GITHUB_TOKEN very easily.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

When running "update-installers-and-pre-commit" pre-commit, the script
is virtually guaranteed to fail with "rate limits" reached if you do
not use GITHUB_TOKEN. This change makes GITHUB_TOKEN variable mandatory
for the pre-commit, it prints the helpful information and prints URL
that allows to create such GITHUB_TOKEN very easily.
@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Jul 17, 2025
Copy link
Collaborator

@aritra24 aritra24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, makes sense! That's a good thought

@potiuk potiuk merged commit aeb0d4c into apache:main Jul 17, 2025
48 checks passed
@potiuk potiuk deleted the make-github-token-mandatory-for-upgrade-installers branch July 17, 2025 14:53
github-actions bot pushed a commit that referenced this pull request Jul 17, 2025
…lers (#53452)

When running "update-installers-and-pre-commit" pre-commit, the script
is virtually guaranteed to fail with "rate limits" reached if you do
not use GITHUB_TOKEN. This change makes GITHUB_TOKEN variable mandatory
for the pre-commit, it prints the helpful information and prints URL
that allows to create such GITHUB_TOKEN very easily.
(cherry picked from commit aeb0d4c)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@github-actions
Copy link

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jul 17, 2025
…lers (apache#53452)

When running "update-installers-and-pre-commit" pre-commit, the script
is virtually guaranteed to fail with "rate limits" reached if you do
not use GITHUB_TOKEN. This change makes GITHUB_TOKEN variable mandatory
for the pre-commit, it prints the helpful information and prints URL
that allows to create such GITHUB_TOKEN very easily.
(cherry picked from commit aeb0d4c)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk added a commit that referenced this pull request Jul 19, 2025
…lers (#53452) (#53457)

When running "update-installers-and-pre-commit" pre-commit, the script
is virtually guaranteed to fail with "rate limits" reached if you do
not use GITHUB_TOKEN. This change makes GITHUB_TOKEN variable mandatory
for the pre-commit, it prints the helpful information and prints URL
that allows to create such GITHUB_TOKEN very easily.
(cherry picked from commit aeb0d4c)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants