Skip to content

Conversation

@jeff3071
Copy link
Contributor

@jeff3071 jeff3071 commented Jul 17, 2025

related: #53395

mypy warning: providers/yandex/src/airflow/providers/yandex/operators/dataproc.py:149: error: Statement is unreachable [unreachable]

caused by:

if services is None:
            services = []

services type hint: Iterable[str] was not allowed be None. mypy think if services is None: condition always false.

fix: add type hint None


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 17, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@gopidesupavan
Copy link
Member

gopidesupavan commented Jul 19, 2025

@jeff3071
Copy link
Contributor Author

i think you can remove this condition itself, https://github.com/apache/airflow/pull/53453/files#diff-f2fbaeacd7184aebb7503aa6285edf361283cb90c932e7709c01ab8dacc23d52R148, because the dataproc accepts None aswell https://github.com/yandex-cloud/python-sdk/blob/master/yandexcloud/_wrappers/dataproc/__init__.py#L68

So addting None type to services args seems fine.

I’ve removed the condition.
Dataproc can take the services argument as None.
Thanks!

@potiuk potiuk merged commit f896807 into apache:main Jul 20, 2025
71 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 20, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Jul 21, 2025
* add yandex type hint

* remove condition check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants