Fix unreachable code mypy warnings in singularity provider #53468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #53395
original warning:
providers/singularity/src/airflow/providers/singularity/operators/singularity.py:176: error: Statement is unreachable [unreachable] [self.log.info](http://self.log.info/)("Stopping Singularity instance")this is caused by:
when mypy infers the type of
self.instanceasNone, it makes theif self.instance is not Nonecondition always false, which makesself.log.info("Stopping Singularity instance")unreachable.fix: use
self.instance: Any = Noneto tell mypy that self.instance can be None or any other typenote: affected
# type: ignore[attr-defined]comments are removed to fix all warnings^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.