Use asyncio.run instead of loop.run_until_complete. #53475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
eladkal
approved these changes
Jul 18, 2025
hussein-awala
approved these changes
Jul 18, 2025
jedcunningham
approved these changes
Jul 18, 2025
dstandish
requested review from
gopidesupavan,
jason810496 and
potiuk
as code owners
This doesn't depend on loop being there, which is a functionality that is deprecated.
dstandish
force-pushed
the
fix-kpo-asyncio-deprecation-warning
branch
from
a265768 to
24c09d5
Compare
dstandish
commented
Jul 21, 2025
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/utils/pod_manager.py
Show resolved
Hide resolved
Contributor
Author
|
Ok -- finally green except for two unrelated flakey tests -- merging |
Contributor
|
@ashb this shouldn't be set for 3.0.4 milestone right? It is a provider only change. |
Member
|
Good point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't depend on loop being there, which is a functionality that is deprecated.