Fix unreachable code mypy warnings in teradata provider #53488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
some mypy checks failing |
fweilun
force-pushed
the
remove-or-fix-unreachable-code-in-teradata-provider
branch
from
9f746f3 to
51a1613
Compare
fweilun
changed the title
Contributor
Author
|
HI @gopidesupavan , I’ve fixed the MyPy warnings for this provider. |
potiuk
force-pushed
the
remove-or-fix-unreachable-code-in-teradata-provider
branch
from
1afdcdc to
c284fe7
Compare
Member
Just rebased. Likely intermittent |
gopidesupavan
approved these changes
Jul 25, 2025
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 7, 2025
* include list[str] in DbApiHook.run return type to resolve MyPy unreachable warnings * fix: update dialect.py return type to match run() * generalize SQL result type from list[str] to list for broader compatibility
fweilun
added a commit
to fweilun/airflow
that referenced
this pull request
Aug 11, 2025
* include list[str] in DbApiHook.run return type to resolve MyPy unreachable warnings * fix: update dialect.py return type to match run() * generalize SQL result type from list[str] to list for broader compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #53395
The
runmethod inDbApiHookdid not includelist[str]as a possible return type,even though certain handlers like
fetch_one_handleror custom handlers can return it.This caused MyPy to raise
unreachablecode errors in providers such asteradatawhen checking for
list[str]results.This commit updates the type annotations in both
sql.pyandsql.pyito reflectthis valid case and unblock downstream MyPy type-checking.
No functional changes. All tests continue to pass.