Pass cluster context to AsyncKubernetesHook#53504
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
potiuk
left a comment
There was a problem hiding this comment.
LGTM But I would love if someone who actually knows our k8s async can take a look at it.
Thanks @potiuk! any recommendation of who I should tag for review? |
We usually don't tag people - they usually volunteer they are not being volunteered. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* ensure cluster context is passed through * reformat --------- Co-authored-by: Alfred Davidson <alfie.davidson9@gmail.com>
* ensure cluster context is passed through * reformat --------- Co-authored-by: Alfred Davidson <alfie.davidson9@gmail.com>
The cluster_context passed into AsyncKubernetesHook is not passed through when load_kube_config_from_dict is called. This causes failures if you are running a KubernetesPodOperator task with deferrable=True and a cluster context that’s different to the default.
Ensuring the cluster_context is passed into the load_kube_config_from_dict method ensures the correct context is used for API calls
This is a duplicate of an auto-closed PR: #44522
related: https://github.com/G-Research/gr-oss/issues/1018
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.