-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add Triggering User Name to the DagRun UI page #53510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Triggering User Name to the DagRun UI page #53510
Conversation
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be OK for me. Would like another UI Experts opinion, unsure whether a specific concept for displayed columns was made. I like this approach but other filter and columns select options are missing atm.
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, that's a great addition.
I think there are a few adjustments to make before we can merge it.
This reverts commit 65ce453.
|
@pierrejeambrun , I removed the filtering completely, this PR just adds the additional column to the DagRun. Please let me know if this looks good |
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
|
Feel free to follow with the backend sort implementation. That should be pretty straight forward there a plenty of example to take a look at. |
|
@pierrejeambrun can we include this in 3.1.0 ? |
|
@dheerajturaga It is on main and 3.1 stable / test branch is not branched-off so it will be for sure in 3.1 (unless somebody reverts). Added the milestone tag to make it clear. |

For DAGs with frequent manual triggers from multiple users, it can be difficult to determine which DagRun corresponds to which user. With the addition of the triggering_user_name field to the DagRun model in #51738, this PR enhances the DagRun UI by displaying the triggering user's name, making it easier to trace manual runs.