Generalize UI Asset build in Plugins #53577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
jscheffl
force-pushed
the
feature/generalize-plugin-asset-build
branch
from
936cdcf to
9f947ca
Compare
vincbeck
reviewed
Jul 30, 2025
jscheffl
force-pushed
the
feature/generalize-plugin-asset-build
branch
from
9f947ca to
6ab467b
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR generalizes the FAB provider asset compilation script to support multiple providers as preparation for reducing complexity in a future PR. The changes refactor hardcoded FAB-specific paths into a configurable dictionary structure and update the compilation function to accept a provider parameter.
- Replaces hardcoded FAB paths with a configurable
PROVIDERS_PATHSdictionary - Updates
compile_assets()function to accept a provider name parameter instead of a direct path - Modifies the pre-commit hook to pass "fab" as an argument to the generalized script
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/ci/pre_commit/compile_provider_assets.py | Generalizes asset compilation from FAB-specific to multi-provider support with configurable paths |
| .pre-commit-config.yaml | Updates pre-commit hook entry point to use generalized script with "fab" parameter |
vincbeck
approved these changes
Jul 30, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
* Generalize UI Asset build in Plugins * Review feedback * Copilot feedback (cherry picked from commit 68b6c36) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Backport successfully created: v3-0-test
|
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Jul 31, 2025
* Generalize UI Asset build in Plugins * Review feedback * Copilot feedback
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 7, 2025
* Generalize UI Asset build in Plugins * Review feedback * Copilot feedback
fweilun
pushed a commit
to fweilun/airflow
that referenced
this pull request
Aug 11, 2025
* Generalize UI Asset build in Plugins * Review feedback * Copilot feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a preparation to reduce complexity in PR #53563 and as "soon" also Edge will build Provider specific assets...
This PR makes a generalization of the pre-commit hook to check an build provider assets. Edge configuration will be added separately