Replace mock.patch("utcnow") with time_machine.
#53642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
requested review from
eladkal,
mik-laj,
mobuchowski,
o-nikolas and
potiuk
as code owners
boring-cyborg
bot
added
area:providers
provider:amazon
Member
Author
|
There are one or two uses in tests in core, but that I will do as part of the mentioned PR -- this one is providers only to isolate changes for release easier. |
ashb
added
the
log exception
Member
Author
|
Added |
kaxil
approved these changes
Jul 22, 2025
jedcunningham
approved these changes
Jul 22, 2025
ashb
force-pushed
the
timemachine-not-patch-utcnow
branch
2 times, most recently
from
f1f1558 to
b2aa877
Compare
potiuk
approved these changes
Jul 22, 2025
eladkal
approved these changes
Jul 22, 2025
As part of a future PR we are going to move the location of this function, and more generally we shouldn't be mocking a specific function, time_machine is better suited to this task. It would be nice if we could add a ruff/etc rule to forbid this, but I can't think of a way of enforcing this.
ashb
force-pushed
the
timemachine-not-patch-utcnow
branch
from
b2aa877 to
31b2eef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of a future PR (#53149) we are going to move the location of this function, and more
generally we shouldn't be mocking a specific function, time_machine is better
suited to this task.
It would be nice if we could add a ruff/etc rule to forbid this, but I can't
think of a way of enforcing this.