add tasksDuration to state run facet #53644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
mobuchowski
force-pushed
the
add-task-duration
branch
from
fbdb159 to
28a1730
Compare
hussein-awala
approved these changes
Aug 6, 2025
Member
|
I'm also ok with adding start and end time, so let's wait for a second opinion. |
kacpermuda
approved these changes
Aug 11, 2025
Contributor
kacpermuda
left a comment
kacpermuda
left a comment
There was a problem hiding this comment.
LGTM, the start/end date approach is also fine, but this is short and clean.
Contributor
Author
|
Thanks! |
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Aug 15, 2025
Signed-off-by: Maciej Obuchowski <maciej.obuchowski@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tasksDuration dict to
AirflowStateRunFacetthat already contains states of the tasks, attached to the event send on DAG success/failure. That is useful if the task level event on the end of execution was not emitted, for example due to https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#task-success-overtimeAlternative would be to add tuple containing startTime, endTime.