Skip to content

Conversation

@zachliu
Copy link
Contributor

@zachliu zachliu commented Jul 23, 2025

closes: #53439

This PR fixes a UI bug where the “All” option in the DAGs list dropdown filter (All / Enabled / Disabled) does not work when the config option hide_paused_dags_by_default = True.

Problem: when hide_paused_dags_by_default is enabled:

  • Visiting /dags shows only enabled DAGs by default (as intended).
  • Selecting “All” from the dropdown does not update the URL with ?paused=all, which causes the page to fall back to config-based filtering and still show only enabled DAGs.
  • This creates a confusing UX where users can see and choose the "All" option from the dropdown but it shows only the enabled DAGs.

Fix: updated the handlePausedChange logic to preserve ?paused=all instead of deleting the query para, which ensures that selecting "All" results in the URL containing ?paused=all, which is correctly handled by the backend.

dropdown-fixed.mp4

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Jul 23, 2025
@zachliu zachliu changed the title this makes "all" not show all dags Fix a UI bug where "All" does not show all dags when hide_paused_dags_by_default = True Jul 23, 2025
@eladkal eladkal added type:bug-fix Changelog: Bug Fixes backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Jul 23, 2025
@eladkal eladkal added this to the Airflow 3.0.4 milestone Jul 23, 2025
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Working as expected.

@pierrejeambrun pierrejeambrun merged commit 5db1b71 into apache:main Jul 23, 2025
56 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 23, 2025
(cherry picked from commit 5db1b71)

Co-authored-by: Zach Liu <zachliu@users.noreply.github.com>
@github-actions
Copy link

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jul 23, 2025
(cherry picked from commit 5db1b71)

Co-authored-by: Zach Liu <zachliu@users.noreply.github.com>
@zachliu zachliu deleted the fix-dag-filter-drop-down branch July 23, 2025 17:36
pierrejeambrun pushed a commit that referenced this pull request Jul 25, 2025
(cherry picked from commit 5db1b71)

Co-authored-by: Zach Liu <zachliu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to show both enabled and disabled dags at the same time (the All option is unresponsive when hide_paused_dags_by_default is set to True)

3 participants