Fixing mypy checks for devel-common on main #53666
Merged
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
reviewed
Jul 23, 2025
kaxil
approved these changes
Jul 23, 2025
Member
kaxil
left a comment
kaxil
left a comment
There was a problem hiding this comment.
The Provider system test uses the watcher. So this needs to work on 2.11 too for now - so I am ok with the change
Member
|
I'd rather |
eladkal
approved these changes
Jul 23, 2025
potiuk
approved these changes
Jul 23, 2025
Member
Indeed. It's not C++ and try/except is faster than version checks usually (and more robust) |
potiuk
approved these changes
Jul 23, 2025
Member
|
Static checks passed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#53629 seems to have broken CI.
Example: https://github.com/apache/airflow/actions/runs/16468038178/job/46550679523?pr=53655
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.