-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add possibility to apply a commit with patch to docs when publishing #53668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc: @jedcunningham -> I think we also need to update the "Helm" releasing docs to use the |
cd5d693 to
2fb4b5b
Compare
You can specify commit hash to apply when you build documentation. This allows to regenerate past version of the documentation by checking out the exact version tag that was used back then and applying the commit hash with fixes. This might help in fixing issues like #53646
2fb4b5b to
217e02f
Compare
|
Ok. Few fixes - I also got some warnings that |
|
I will merge it when it gets green and test the full workflow with it. |
|
I had to add some workaround for documentation released before we released airflow 3 (hive 9.0.0) because image stopped building for those - but I found a workaround how to fall-back and build it more |
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker d6a51e9 v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
…pache#53668) You can specify commit hash to apply when you build documentation. This allows to regenerate past version of the documentation by checking out the exact version tag that was used back then and applying the commit hash with fixes. This might help in fixing issues like apache#53646 (cherry picked from commit d6a51e9)
… publishing (#53668) (#53678) You can specify commit hash to apply when you build documentation. This allows to regenerate past version of the documentation by checking out the exact version tag that was used back then and applying the commit hash with fixes. This might help in fixing issues like #53646 (cherry picked from commit d6a51e9)
| for APPLY_COMMIT in "${COMMIT_ARRAY[@]}"; do | ||
| echo "Applying commit ${APPLY_COMMIT}" | ||
| git fetch origin "${APPLY_COMMIT}" | ||
| git cherry-pick "${APPLY_COMMIT}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does it cause any conflicts and fail when cherry-picking?
|
thanks nice change :) |
You can specify commit hash to apply when you build documentation. This allows to regenerate past version of the documentation by checking out the exact version tag that was used back then and applying the commit hash with fixes.
This might help in fixing issues like
#53646
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.