Skip to content

Restore execute_complete functionality TimeSensor when deferrable=True #53669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amoghrajesh merged 6 commits into from
Aug 6, 2025
Merged

Restore execute_complete functionality TimeSensor when deferrable=True #53669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a7eb92b
Resolving #53591 to restore execute_complete functionality
jroachgolf84 Jul 23, 2025
7b59660
Adding unit-test for changes to execute_complete
jroachgolf84 Jul 23, 2025
283bcba
Added call to super().execute(...)
jroachgolf84 Jul 25, 2025
28c6b47
Added call to super().execute(...)
jroachgolf84 Jul 25, 2025
0202939
Merge branch 'main' into issue-53591
jroachgolf84 Jul 31, 2025
af75f2c
Update providers/standard/src/airflow/providers/standard/sensors/time.py
jroachgolf84 Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions providers/standard/src/airflow/providers/standard/sensors/time.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,11 @@ def execute(self, context: Context) -> None:
),
method_name="execute_complete",
)
else:
super().execute(context)

def execute_complete(self, context: Context) -> None:
return
def execute_complete(self, context: Context, event: Any = None) -> None:
return None

def poke(self, context: Context) -> bool:
self.log.info("Checking if the time (%s) has come", self.target_datetime)
Expand Down
14 changes: 14 additions & 0 deletions providers/standard/tests/unit/standard/sensors/test_time.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,3 +124,17 @@ def test_task_is_deferred(self):
assert exc_info.value.trigger.moment == pendulum.datetime(2020, 7, 7, 10)
assert exc_info.value.kwargs is None
assert exc_info.value.method_name == "execute_complete"

def test_execute_complete_accepts_event(self):
"""Ensure execute_complete supports the 'event' kwarg when deferrable=True."""
with DAG(
dag_id="test_execute_complete_accepts_event",
schedule=None,
start_date=datetime(2020, 1, 1), # Matches above
):
op = TimeSensor(task_id="test", target_time=time(10, 0), deferrable=True)

try:
op.execute_complete(context={}, event={"status": "success"})
except TypeError as e:
pytest.fail(f"TypeError raised: {e}")
Loading