Improve validation of breeze workflow-run command #53685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workflow run command validation had few places where the validation could be improved: * when you do not specify packages, the workflow has no idea what to build, so the list of packages should not be empty * when gh has an old version, some of the functionality might not work - we are checking gh version to check if it is old enough.
potiuk
requested review from
amoghrajesh,
ashb,
gopidesupavan and
jedcunningham
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
gopidesupavan
approved these changes
Jul 23, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jul 23, 2025
The workflow run command validation had few places where the validation could be improved: * when you do not specify packages, the workflow has no idea what to build, so the list of packages should not be empty * when gh has an old version, some of the functionality might not work - we are checking gh version to check if it is old enough. (cherry picked from commit 0dc9105) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Backport successfully created: v3-0-test
|
potiuk
added a commit
that referenced
this pull request
Jul 23, 2025
#53688) The workflow run command validation had few places where the validation could be improved: * when you do not specify packages, the workflow has no idea what to build, so the list of packages should not be empty * when gh has an old version, some of the functionality might not work - we are checking gh version to check if it is old enough. (cherry picked from commit 0dc9105) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow run command validation had few places where the validation could be improved:
when you do not specify packages, the workflow has no idea what to build, so the list of packages should not be empty
when gh has an old version, some of the functionality might not work - we are checking gh version to check if it is old enough.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.