Skip to content

Fix SqlAlchemy URI Construction in ExasolHook #53798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 6 commits into from
Sep 12, 2025
Merged

Fix SqlAlchemy URI Construction in ExasolHook #53798

potiuk merged 6 commits into from
Sep 12, 2025
+129 −1

Conversation

@BrianLii
Copy link
Contributor

@BrianLii BrianLii commented Jul 27, 2025 •
edited
Loading

Related: #38195

Why

The current implementation of URI construction in ExasolHook does not return the correct SQLAlchemy driver name.

What

This PR adds support for a sqlalchemy_scheme parameter, enabling users to explicitly define the driver to be used in the SQLAlchemy URI.

This behavior is consistent with other hooks like MsSqlHook, which already provide a similar option.

@eladkal eladkal requested a review from jason810496 September 1, 2025 03:15
@BrianLii BrianLii marked this pull request as ready for review September 2, 2025 15:06
jason810496
jason810496 approved these changes Sep 12, 2025
View reviewed changes
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the PR!

@potiuk potiuk merged commit 39022e0 into apache:main Sep 12, 2025
138 checks passed
suman-himanshu pushed a commit to suman-himanshu/airflow that referenced this pull request Sep 17, 2025
@BrianLii @suman-himanshu
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
1bc39ca 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
Brunda10 pushed a commit to Brunda10/airflow that referenced this pull request Sep 17, 2025
@BrianLii @Brunda10
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
2c2072c 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
@eladkal eladkal mentioned this pull request Sep 18, 2025
Closed
78 tasks
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Sep 30, 2025
@BrianLii
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
806f2a3 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 1, 2025
@BrianLii
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
cbb66a7 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 2, 2025
@BrianLii
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
2514624 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 3, 2025
@BrianLii
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
070c1e1 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 4, 2025
@BrianLii
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
d5906d5 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
@BrianLii
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
8a1593e 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
@BrianLii
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
4c66a5c 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
@BrianLii
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
195e1cc 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
@BrianLii
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
a234a29 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
@BrianLii
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
1f48410 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
@BrianLii
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
47da263 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
@BrianLii
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
d032f31 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
@BrianLii
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
ee0aa9a 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
@BrianLii
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
703c0a2 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
@BrianLii
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
3253ab0 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
@BrianLii
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
5fdf7a2 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
@BrianLii
Fix SqlAlchemy URI Construction in ExasolHook (apache#53798)
3f34794 
* feat: implement sqlalchemy_scheme

* feat: implement sqlalchemy url and unit test

* refactor: move sqlalchemy scheme test to separate class

* refactor: refactor unit test

* feat: add test for get_uri
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@jason810496 jason810496 jason810496 approved these changes

Assignees

No one assigned

Labels

area:providers provider:exasol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BrianLii @potiuk @jason810496