-
Notifications
You must be signed in to change notification settings - Fork 16.4k
bugfix(airflowctl): Prevent BaseOperations to be a command and fix bugs #53800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bugraoz93
merged 10 commits into
apache:main
from
bugraoz93:bugfix/airflowctl/exclude-base-operations
Jul 30, 2025
Merged
bugfix(airflowctl): Prevent BaseOperations to be a command and fix bugs #53800
bugraoz93
merged 10 commits into
apache:main
from
bugraoz93:bugfix/airflowctl/exclude-base-operations
Jul 30, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prab-27
reviewed
Jul 28, 2025
e0335a2 to
f35297c
Compare
Contributor
Author
|
I have added a couple of fixes while testing the commands and deleted a TODO, which is implemented |
gopidesupavan
approved these changes
Jul 30, 2025
Member
gopidesupavan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…er debugging for user and remove additional print
2822f12 to
2392f23
Compare
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Jul 31, 2025
…gs (apache#53800) * bugfix(airflowctl): fix BaseOperations to be a command and fix variable name * bugfix(airflowctl): fix hash and update warning * bugfix(airflowctl): add environment info to log in exception for better debugging for user and remove additional print * bugfix(airflowctl): print client side errors and fix dagrun operations endpoints * bugfix(airflowctl): create dag_run to trigger dag_run * bugfix(airflowctl): update error messages * bugfix(airflowctl): update dag_run to dagRuns * bugfix(airflowctl): update command name and add update operation to output * bugfix(airflowctl): early return for pure dict values for output for get operations * bugfix(airflowctl): remove TODO which already implemented
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 7, 2025
…gs (apache#53800) * bugfix(airflowctl): fix BaseOperations to be a command and fix variable name * bugfix(airflowctl): fix hash and update warning * bugfix(airflowctl): add environment info to log in exception for better debugging for user and remove additional print * bugfix(airflowctl): print client side errors and fix dagrun operations endpoints * bugfix(airflowctl): create dag_run to trigger dag_run * bugfix(airflowctl): update error messages * bugfix(airflowctl): update dag_run to dagRuns * bugfix(airflowctl): update command name and add update operation to output * bugfix(airflowctl): early return for pure dict values for output for get operations * bugfix(airflowctl): remove TODO which already implemented
fweilun
pushed a commit
to fweilun/airflow
that referenced
this pull request
Aug 11, 2025
…gs (apache#53800) * bugfix(airflowctl): fix BaseOperations to be a command and fix variable name * bugfix(airflowctl): fix hash and update warning * bugfix(airflowctl): add environment info to log in exception for better debugging for user and remove additional print * bugfix(airflowctl): print client side errors and fix dagrun operations endpoints * bugfix(airflowctl): create dag_run to trigger dag_run * bugfix(airflowctl): update error messages * bugfix(airflowctl): update dag_run to dagRuns * bugfix(airflowctl): update command name and add update operation to output * bugfix(airflowctl): early return for pure dict values for output for get operations * bugfix(airflowctl): remove TODO which already implemented
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bugs and prevents the
BaseOperationsclass from being a command.Image generation isn't affected because they are chosen per command in the pre-commit script.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.