Skip to content

Conversation

@bugraoz93
Copy link
Contributor

@bugraoz93 bugraoz93 commented Jul 27, 2025

Fixes bugs and prevents the BaseOperations class from being a command.
Image generation isn't affected because they are chosen per command in the pre-commit script.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@bugraoz93 bugraoz93 requested review from kaxil and potiuk as code owners July 27, 2025 20:09
@bugraoz93 bugraoz93 changed the title bugfix(airflowctl): Prevent BaseOperations to be a command and fix variable naming bugfix(airflowctl): Prevent BaseOperations to be a command and fix bugs Jul 27, 2025
@bugraoz93 bugraoz93 force-pushed the bugfix/airflowctl/exclude-base-operations branch 3 times, most recently from e0335a2 to f35297c Compare July 29, 2025 20:01
@bugraoz93
Copy link
Contributor Author

I have added a couple of fixes while testing the commands and deleted a TODO, which is implemented

Copy link
Member

@gopidesupavan gopidesupavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bugraoz93 bugraoz93 force-pushed the bugfix/airflowctl/exclude-base-operations branch from 2822f12 to 2392f23 Compare July 30, 2025 20:24
@bugraoz93 bugraoz93 merged commit 00d68ed into apache:main Jul 30, 2025
9 checks passed
RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Jul 31, 2025
…gs (apache#53800)

* bugfix(airflowctl): fix BaseOperations to be a command and fix variable name

* bugfix(airflowctl): fix hash and update warning

* bugfix(airflowctl): add environment info to log in exception for better debugging for user and remove additional print

* bugfix(airflowctl): print client side errors and fix dagrun operations endpoints

* bugfix(airflowctl): create dag_run to trigger dag_run

* bugfix(airflowctl): update error messages

* bugfix(airflowctl): update dag_run to dagRuns

* bugfix(airflowctl): update command name and add update operation to output

* bugfix(airflowctl): early return for pure dict values for output for get operations

* bugfix(airflowctl): remove TODO which already implemented
ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 7, 2025
…gs (apache#53800)

* bugfix(airflowctl): fix BaseOperations to be a command and fix variable name

* bugfix(airflowctl): fix hash and update warning

* bugfix(airflowctl): add environment info to log in exception for better debugging for user and remove additional print

* bugfix(airflowctl): print client side errors and fix dagrun operations endpoints

* bugfix(airflowctl): create dag_run to trigger dag_run

* bugfix(airflowctl): update error messages

* bugfix(airflowctl): update dag_run to dagRuns

* bugfix(airflowctl): update command name and add update operation to output

* bugfix(airflowctl): early return for pure dict values for output for get operations

* bugfix(airflowctl): remove TODO which already implemented
fweilun pushed a commit to fweilun/airflow that referenced this pull request Aug 11, 2025
…gs (apache#53800)

* bugfix(airflowctl): fix BaseOperations to be a command and fix variable name

* bugfix(airflowctl): fix hash and update warning

* bugfix(airflowctl): add environment info to log in exception for better debugging for user and remove additional print

* bugfix(airflowctl): print client side errors and fix dagrun operations endpoints

* bugfix(airflowctl): create dag_run to trigger dag_run

* bugfix(airflowctl): update error messages

* bugfix(airflowctl): update dag_run to dagRuns

* bugfix(airflowctl): update command name and add update operation to output

* bugfix(airflowctl): early return for pure dict values for output for get operations

* bugfix(airflowctl): remove TODO which already implemented
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants