-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix custom xcom backend deserialize when BaseXCom.get_all is used #53814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Jul 29, 2025
uranusjr
approved these changes
Jul 29, 2025
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker a8c4ba3 v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Jul 31, 2025
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 7, 2025
fweilun
pushed a commit
to fweilun/airflow
that referenced
this pull request
Aug 11, 2025
kaxil
pushed a commit
that referenced
this pull request
Aug 11, 2025
(cherry picked from commit a8c4ba3)
This was referenced Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #53432
Problem
The
BaseXCom.get_all()method was directly calling deserialize() from the serialization module instead of using the overridable cls.deserialize_value() method. This broke custom XCom backends that rely on overridingdeserialize_value()to implement custom deserialization logic.Example of broken behavior:
Root Cause
The issue comes from inconsistent deserialization patterns:
cls.deserialize_value(msg)where msg is anXComResultwith a value attributedeserialize(msg.root)directly, wheremsg.rootis alist[JsonValue]The deserialize_value() method expects an object with a value attribute, but the sequence slice returns a flat list of serialized values.
_XComValueWrapperthat provides.valueas neededTesting
DAG:
Write a custom xcom backend:
Run breeze with:
Validate if the right one got loaded:
Run the dag:
Push task

Pull task

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.