fix(hitl): handle HITLDetail when task instance is retried
#53824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:API
Lee-W
changed the title
HITLDetail when task instance is retried
jscheffl
approved these changes
Jul 28, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Except a mypy nit and two minor things looking good for me.
airflow-core/src/airflow/api_fastapi/execution_api/routes/hitl.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/execution_api/routes/hitl.py
Outdated
Show resolved
Hide resolved
1. If a HITLOperator task instance does not have a HITLDetail,
a new HITLDetail is created without a response section.
2. If a HITLOperator task instance has a HITLDetail but lacks a response,
the existing HITLDetail is returned.
This situation occurs when a task instance is cleared before a response is received.
3. If a HITLOperator task instance has both a HITLDetail and a response section,
the existing response is removed, and the HITLDetail is returned.
This happens when a task instance is cleared after a response has been received.
This design ensures that each task instance has only one HITLDetail.
Lee-W
force-pushed
the
handle-retry-cases-for-hitl-details
branch
from
c207618 to
f224de9
Compare
github-project-automation
bot
moved this from In review
to Done
in AIP-90 - Human in the loop
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Jul 31, 2025
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 7, 2025
fweilun
pushed a commit
to fweilun/airflow
that referenced
this pull request
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
If we clear a
HITLOperatortask instance today, it breaks because there's an existingHITLDetail, and it is not allowed to add a new one.What
The handling is now updated to the following
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.