Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-4750] Log identified zombie task instances #5389

Merged
merged 1 commit into from
Jun 13, 2019

Conversation

chrismclennon
Copy link
Contributor

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

Description

While troubleshooting task instances that were unexpectedly killed I found it helpful to confirm whether the task was identified as a zombie by printing to log.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    • No unit test appears to be productive for printing to log.

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Code Quality

  • Passes flake8

@codecov-io
Copy link

Codecov Report

Merging #5389 into master will increase coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5389      +/-   ##
==========================================
+ Coverage   78.75%   78.94%   +0.18%     
==========================================
  Files         481      481              
  Lines       30201    30203       +2     
==========================================
+ Hits        23786    23843      +57     
+ Misses       6415     6360      -55
Impacted Files Coverage Δ
airflow/utils/dag_processing.py 60.27% <100%> (+0.13%) ⬆️
airflow/operators/postgres_operator.py 0% <0%> (-100%) ⬇️
airflow/hooks/postgres_hook.py 94.64% <0%> (-1.79%) ⬇️
airflow/hooks/dbapi_hook.py 86.84% <0%> (-0.88%) ⬇️
airflow/models/connection.py 65% <0%> (+1.11%) ⬆️
airflow/hooks/hive_hooks.py 77.72% <0%> (+1.77%) ⬆️
airflow/utils/sqlalchemy.py 79.76% <0%> (+3.57%) ⬆️
airflow/operators/mysql_operator.py 100% <0%> (+100%) ⬆️
airflow/operators/mysql_to_hive.py 100% <0%> (+100%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb506b...e846903. Read the comment docs.

airflow/utils/dag_processing.py Outdated Show resolved Hide resolved
Copy link
Contributor

@tooptoop4 tooptoop4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Log does not have the word zombie?

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As pointed out by tooptoop4 (and lets make the dates logged by iso8601 format rather than "almost")

airflow/utils/dag_processing.py Outdated Show resolved Hide resolved
airflow/utils/dag_processing.py Outdated Show resolved Hide resolved
@chrismclennon
Copy link
Contributor Author

Good recommendations. I've adjusted the language a bit and added isoformat. Thanks

@ashb ashb merged commit d89c17d into apache:master Jun 13, 2019
ashb pushed a commit that referenced this pull request Jun 13, 2019
tiopi pushed a commit to tiopi/airflow that referenced this pull request Jun 14, 2019
# This is the 1st commit message:

[AIRFLOW-4750] Log identified zombie task instances (apache#5389)


# This is the commit message apache#2:

Added Sentry to contrib folder

# This is the commit message apache#3:

Added Sentry to contrib folder
tiopi pushed a commit to tiopi/airflow that referenced this pull request Jun 14, 2019
ashb pushed a commit to ashb/airflow that referenced this pull request Jun 18, 2019
andriisoldatenko pushed a commit to andriisoldatenko/airflow that referenced this pull request Jul 26, 2019
wmorris75 pushed a commit to modmed/incubator-airflow that referenced this pull request Jul 29, 2019
dharamsk pushed a commit to postmates/airflow that referenced this pull request Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants