-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-4750] Log identified zombie task instances #5389
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5389 +/- ##
==========================================
+ Coverage 78.75% 78.94% +0.18%
==========================================
Files 481 481
Lines 30201 30203 +2
==========================================
+ Hits 23786 23843 +57
+ Misses 6415 6360 -55
Continue to review full report at Codecov.
|
e846903
to
b1d7732
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Log does not have the word zombie?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As pointed out by tooptoop4 (and lets make the dates logged by iso8601 format rather than "almost")
b1d7732
to
d3ad93f
Compare
Good recommendations. I've adjusted the language a bit and added isoformat. Thanks |
(cherry picked from commit d89c17d)
# This is the 1st commit message: [AIRFLOW-4750] Log identified zombie task instances (apache#5389) # This is the commit message apache#2: Added Sentry to contrib folder # This is the commit message apache#3: Added Sentry to contrib folder
(cherry picked from commit d89c17d)
(cherry picked from commit d89c17d)
Make sure you have checked all steps below.
Jira
Description
While troubleshooting task instances that were unexpectedly killed I found it helpful to confirm whether the task was identified as a zombie by printing to log.
Tests
Commits
Documentation
Code Quality
flake8