-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Remove query obj from providers fab #53953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vincbeck
merged 11 commits into
apache:main
from
Prab-27:remove-query-obj-from-providers-fab
Aug 29, 2025
Merged
Remove query obj from providers fab #53953
vincbeck
merged 11 commits into
apache:main
from
Prab-27:remove-query-obj-from-providers-fab
Aug 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
953c467 to
56773ae
Compare
56773ae to
9412a3a
Compare
Member
|
conflicts to solve :( |
Contributor
Author
|
I need to deep dive into pre-commit hook because it doesn't detect certain patterns |
64867c1 to
380232d
Compare
vincbeck
approved these changes
Aug 28, 2025
Contributor
Author
|
Thanks I'll update pre-commit hook |
380232d to
a9772b4
Compare
Contributor
Author
|
Sorry! I forgot to include this earlier. It's updated now. |
Contributor
|
Nice! It detected some missing then (a good proof it works :)) |
Contributor
Author
|
Apologies—some query objects were still present. I should have reviewed them earlier. I'll update the code shortly |
a9772b4 to
7db69c1
Compare
vincbeck
approved these changes
Aug 29, 2025
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
nothingmin
pushed a commit
to nothingmin/airflow
that referenced
this pull request
Sep 2, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
* remove session.query from tests * remove session.query from fab/src * fix errors * Removed unnecessary comments code and applied small fixes * resolved conflict and removed session.query from it * remove .query() * fix static checks * fix static checks * fix import error * include fab provider in pre-commit check * remove query obj from test_user_endpoint
74 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related discussion : here
This PR is part of the migration to SQLAlchemy 2.0
Removed session.query() from src and tests
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.