Skip to content

refactor(hitl): replace timezone usage with airflow.sdk.timezone #53962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lee-W merged 2 commits into from
Aug 4, 2025
Merged

refactor(hitl): replace timezone usage with airflow.sdk.timezone #53962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b51d8a4
feat(hitl): replace airflow.utils.timezone with airflow.sdk.timezone …
Lee-W Jul 31, 2025
f2517f3
feat(hitl): replace datetime.now(timezone.utc) as airflow.sdk.timezon…
Lee-W Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions providers/standard/src/airflow/providers/standard/operators/hitl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@


from collections.abc import Collection, Mapping
from datetime import datetime, timezone
from typing import TYPE_CHECKING, Any

from airflow.providers.standard.exceptions import HITLTimeoutError, HITLTriggerEventError
Expand All @@ -36,6 +35,7 @@
from airflow.providers.standard.version_compat import BaseOperator
from airflow.sdk.definitions.param import ParamsDict
from airflow.sdk.execution_time.hitl import upsert_hitl_detail
from airflow.sdk.timezone import utcnow

if TYPE_CHECKING:
from airflow.sdk.definitions.context import Context
Expand Down Expand Up @@ -109,7 +109,7 @@ def execute(self, context: Context):
params=self.serialized_params,
)
if self.execution_timeout:
timeout_datetime = datetime.now(timezone.utc) + self.execution_timeout
timeout_datetime = utcnow() + self.execution_timeout
else:
timeout_datetime = None
self.log.info("Waiting for response")
Expand Down
4 changes: 2 additions & 2 deletions providers/standard/src/airflow/providers/standard/triggers/hitl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@
get_hitl_detail_content_detail,
update_htil_detail_response,
)
from airflow.sdk.timezone import utcnow
from airflow.triggers.base import BaseTrigger, TriggerEvent
from airflow.utils import timezone


class HITLTriggerEventSuccessPayload(TypedDict, total=False):
Expand Down Expand Up @@ -97,7 +97,7 @@ def serialize(self) -> tuple[str, dict[str, Any]]:
async def run(self) -> AsyncIterator[TriggerEvent]:
"""Loop until the Human-in-the-loop response received or timeout reached."""
while True:
if self.timeout_datetime and self.timeout_datetime < timezone.utcnow():
if self.timeout_datetime and self.timeout_datetime < utcnow():
if self.defaults is None:
yield TriggerEvent(
HITLTriggerEventFailurePayload(
Expand Down