Make log redaction safer in edge case when redaction has an error #54046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this both logged the item, and returned the unable-to-be-redacted item unchanged. Lets play it safe, only log the type that failed and return a known-to-be-safe string in cases like this.
ashb
added
the
backport-to-v3-1-test
potiuk
approved these changes
Aug 2, 2025
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 2, 2025
…an error (apache#54046) (cherry picked from commit 93ba1c5) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
github-actions bot
pushed a commit
to guan404ming/airflow
that referenced
this pull request
Aug 2, 2025
…an error (apache#54046) (cherry picked from commit 93ba1c5) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 7, 2025
fweilun
pushed a commit
to fweilun/airflow
that referenced
this pull request
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this both logged the item, and returned the unable-to-be-redacted item unchanged.
Lets play it safe, only log the type that failed and return a known-to-be-safe string in cases like this.