Re-introduce TypeGuard to SecretsMasker #54055
Merged
+17
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've upraded to MyPy 1.17.0 now, so we can use the type guard again. Also remove the redundant hasattr check - it was only needed because of incorrect mocking in tests.
gopidesupavan
approved these changes
Aug 2, 2025
Member
gopidesupavan
left a comment
gopidesupavan
left a comment
There was a problem hiding this comment.
Thanks for updating it :)
Member
|
Nice! |
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 7, 2025
We've upraded to MyPy 1.17.0 now, so we can use the type guard again. Also remove the redundant hasattr check - it was only needed because of incorrect mocking in tests.
fweilun
pushed a commit
to fweilun/airflow
that referenced
this pull request
Aug 11, 2025
We've upraded to MyPy 1.17.0 now, so we can use the type guard again. Also remove the redundant hasattr check - it was only needed because of incorrect mocking in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've upraded to MyPy 1.17.0 now, so we can use the type guard again.
Also remove the redundant hasattr check - it was only needed because of incorrect mocking in tests. This was identified in #54048 where I fixed it for a backport
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.