Remove deprecated method check send_file usage from slack operators #54061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gopidesupavan
requested review from
jscheffl,
potiuk,
shahar1 and
vatsrahul1001
gopidesupavan
commented
Aug 2, 2025
gopidesupavan
force-pushed
the
remove-slack-deprectated-calls
branch
2 times, most recently
from
83b5675 to
261dc60
Compare
jscheffl
approved these changes
Aug 3, 2025
eladkal
reviewed
Aug 4, 2025
gopidesupavan
force-pushed
the
remove-slack-deprectated-calls
branch
from
e1a8c97 to
af6518f
Compare
potiuk
approved these changes
Aug 5, 2025
Nataneljpwd
pushed a commit
to Asquator/airflow
that referenced
this pull request
Aug 5, 2025
…pache#54061) * Remove deprecated method check send_file usage from slack operators * Fix tests * Update warning * Remove slack_sdk version bump
HsiuChuanHsu
pushed a commit
to HsiuChuanHsu/airflow
that referenced
this pull request
Aug 5, 2025
…pache#54061) * Remove deprecated method check send_file usage from slack operators * Fix tests * Update warning * Remove slack_sdk version bump
40 tasks
ferruzzi
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 7, 2025
…pache#54061) * Remove deprecated method check send_file usage from slack operators * Fix tests * Update warning * Remove slack_sdk version bump
fweilun
pushed a commit
to fweilun/airflow
that referenced
this pull request
Aug 11, 2025
…pache#54061) * Remove deprecated method check send_file usage from slack operators * Fix tests * Update warning * Remove slack_sdk version bump
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have removed send_file deprecation method part of this #44693.
There were some leftovers of usage of
send_fileeg: https://github.com/apache/airflow/blob/main/providers/slack/src/airflow/providers/slack/operators/slack.py#L245, this would fail if anyone sends v1 as there is no send_file method in hooks.We should remove now usages.
As we removed method_resolver function, we dont need of the method_version argument at all, for now added deprecation warning if anyone uses this would notify the default is slack_sdk file_upload_v2.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.