Skip to content

fix(snowflake): Improve 422 SQL error message formatting in SnowflakeSqlApiHook #54063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 4 commits into from
Aug 15, 2025
Merged

fix(snowflake): Improve 422 SQL error message formatting in SnowflakeSqlApiHook #54063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd1c972
fix(snowflake): enhance error message formatting for SQL errors
prdai Aug 3, 2025
cc1f434
Merge branch 'main' into feature/snowflake-sqlapi-operator-422-error-…
rawwar Aug 13, 2025
7363b2f
Merge branch 'main' into feature/snowflake-sqlapi-operator-422-error-…
prdai Aug 13, 2025
7cbf66c
Merge branch 'main' into feature/snowflake-sqlapi-operator-422-error-…
prdai Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion providers/snowflake/src/airflow/providers/snowflake/hooks/snowflake_sql_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,21 @@ def _process_response(self, status_code, resp):
if status_code == 202:
return {"status": "running", "message": "Query statements are still running"}
if status_code == 422:
return {"status": "error", "message": resp["message"]}
error_message = resp.get("message", "Unknown error occurred")
error_details = []
if code := resp.get("code"):
error_details.append(f"Code: {code}")
if sql_state := resp.get("sqlState"):
error_details.append(f"SQL State: {sql_state}")
if statement_handle := resp.get("statementHandle"):
error_details.append(f"Statement Handle: {statement_handle}")

if error_details:
enhanced_message = f"{error_message} ({', '.join(error_details)})"
else:
enhanced_message = error_message

return {"status": "error", "message": enhanced_message}
if status_code == 200:
if resp_statement_handles := resp.get("statementHandles"):
statement_handles = resp_statement_handles
Expand Down
17 changes: 15 additions & 2 deletions providers/snowflake/tests/unit/snowflake/hooks/test_snowflake_sql_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,20 @@ def test_get_private_key_should_support_private_auth_with_unencrypted_key(
},
),
(202, {}, {"status": "running", "message": "Query statements are still running"}),
(422, {"status": "error", "message": "test"}, {"status": "error", "message": "test"}),
(422, {"message": "test"}, {"status": "error", "message": "test"}),
(
422,
{
"message": "SQL compilation error",
"code": "000904",
"sqlState": "42000",
"statementHandle": "handle123",
},
{
"status": "error",
"message": "SQL compilation error (Code: 000904, SQL State: 42000, Statement Handle: handle123)",
},
),
(404, {"status": "error", "message": "test"}, {"status": "error", "message": "test"}),
],
)
Expand Down Expand Up @@ -678,7 +691,7 @@ def raise_for_status(self):
},
),
(202, {}, {"status": "running", "message": "Query statements are still running"}),
(422, {"status": "error", "message": "test"}, {"status": "error", "message": "test"}),
(422, {"message": "test"}, {"status": "error", "message": "test"}),
(404, {"status": "error", "message": "test"}, {"status": "error", "message": "test"}),
],
)
Expand Down
Loading