-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add cluster_tier flag support to Dataproc ClusterGenerator #54105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
providers/google/src/airflow/providers/google/cloud/operators/dataproc.py
Outdated
Show resolved
Hide resolved
|
Fail seems unrelated, some other version conflicts: |
I think it has been fixed on the main branch. Rebase from the main branch and retry might fix it |
|
@Lee-W Can you re-run the tests |
|
@Lee-W can we merge 🚀 |
|
Let's wait for one or two days in case someone wants to take another look :) Will merge it then. Thanks for making airflow better! |
|
time to merge it 🚀 |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This change adds a 'cluster_tier' flag to the ClusterGenerator, allowing users to specify the cluster tier during Dataproc cluster creation. This functionality is enabled by bumping the 'google-cloud-dataproc' pip package to version 5.21.0, which includes the necessary changes to support the new flag.
ClusterGenerator is an internal helper function that is used to generate cluster configs that is then used to pass to DataprocCreateClusterOperator dag (https://airflow.apache.org/docs/apache-airflow-providers-google/stable/operators/cloud/dataproc.html#generating-cluster-config)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.