Skip to content

Conversation

@swainmoc
Copy link
Contributor

@swainmoc swainmoc commented Aug 4, 2025

This change adds a 'cluster_tier' flag to the ClusterGenerator, allowing users to specify the cluster tier during Dataproc cluster creation. This functionality is enabled by bumping the 'google-cloud-dataproc' pip package to version 5.21.0, which includes the necessary changes to support the new flag.

ClusterGenerator is an internal helper function that is used to generate cluster configs that is then used to pass to DataprocCreateClusterOperator dag (https://airflow.apache.org/docs/apache-airflow-providers-google/stable/operators/cloud/dataproc.html#generating-cluster-config)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 4, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Aug 4, 2025
@swainmoc swainmoc requested a review from VladaZakharova August 5, 2025 19:26
@swainmoc swainmoc requested a review from Lee-W August 11, 2025 11:28
@swainmoc
Copy link
Contributor Author

swainmoc commented Aug 11, 2025

Fail seems unrelated, some other version conflicts:

  241.5   × Failed to download and build `xmlsec==1.3.16`
  241.5   ╰─▶ Package metadata version `0.0.0` does not match given version `1.3.16`
  241.5   help: `xmlsec` (v1.3.16) was included because
  241.5         `apache-airflow-providers-amazon[python3-saml]` (v9.12.0) depends
  241.5         on `xmlsec`

@Lee-W
Copy link
Member

Lee-W commented Aug 11, 2025

Fail seems unrelated, some other version conflicts:

  241.5   × Failed to download and build `xmlsec==1.3.16`
  241.5   ╰─▶ Package metadata version `0.0.0` does not match given version `1.3.16`
  241.5   help: `xmlsec` (v1.3.16) was included because
  241.5         `apache-airflow-providers-amazon[python3-saml]` (v9.12.0) depends
  241.5         on `xmlsec`

I think it has been fixed on the main branch. Rebase from the main branch and retry might fix it

@swainmoc
Copy link
Contributor Author

@Lee-W Can you re-run the tests

@swainmoc
Copy link
Contributor Author

@Lee-W can we merge 🚀

@Lee-W
Copy link
Member

Lee-W commented Aug 12, 2025

Let's wait for one or two days in case someone wants to take another look :) Will merge it then. Thanks for making airflow better!

@Lee-W
Copy link
Member

Lee-W commented Aug 15, 2025

time to merge it 🚀

@Lee-W Lee-W merged commit 9ade787 into apache:main Aug 15, 2025
87 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 15, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants