Skip to content

fix typo in AdminClientHook.create_subscription #54130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eladkal merged 1 commit into from
Aug 5, 2025
Merged

fix typo in AdminClientHook.create_subscription #54130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion providers/microsoft/azure/src/airflow/providers/microsoft/azure/hooks/asb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ def create_subscription(
lock_duration=lock_duration,
requires_session=requires_session,
default_message_time_to_live=default_message_time_to_live,
dead_lettering_on_ßmessage_expiration=dead_lettering_on_message_expiration,
dead_lettering_on_message_expiration=dead_lettering_on_message_expiration,
dead_lettering_on_filter_evaluation_exceptions=dead_lettering_on_filter_evaluation_exceptions,
max_delivery_count=max_delivery_count,
enable_batched_operations=enable_batched_operations,
Expand Down
18 changes: 17 additions & 1 deletion providers/microsoft/azure/tests/unit/microsoft/azure/hooks/test_asb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,23 @@ def test_create_subscription(self, mock_sb_admin_client, mock_subscription_prope
mock_subscription_properties
)
hook = AdminClientHook(azure_service_bus_conn_id=self.conn_id)
hook.create_subscription(topic_name, subscription_name)
hook.create_subscription(topic_name, subscription_name, dead_lettering_on_message_expiration=False)

mock_sb_admin_client.return_value.__enter__.return_value.create_subscription.assert_called_once_with(
topic_name=topic_name,
subscription_name=subscription_name,
lock_duration=None,
requires_session=None,
default_message_time_to_live=None,
dead_lettering_on_message_expiration=False,
dead_lettering_on_filter_evaluation_exceptions=None,
max_delivery_count=10,
enable_batched_operations=True,
forward_to=None,
user_metadata=None,
forward_dead_lettered_messages_to=None,
auto_delete_on_idle=None,
)
assert mock_subscription_properties.name == subscription_name

# Test creating subscription with topic name, subscription name, correlation rule and rule naame
Expand Down
Loading