Skip to content

Conversation

@astro-anand
Copy link
Contributor

Adjusted order of operations to run custom serialization first before checking if subclass of base object

closes: #54097


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@astro-anand astro-anand changed the title Fix numpy serialization order of ops Fix serialization order of ops Aug 5, 2025
@potiuk potiuk added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Aug 5, 2025
@potiuk
Copy link
Member

potiuk commented Aug 5, 2025

Nice! Let's see if CI agrees :)

@astro-anand
Copy link
Contributor Author

@potiuk looks like CI agrees 😌

@potiuk potiuk merged commit 634b797 into apache:main Aug 5, 2025
58 checks passed
@github-actions
Copy link

github-actions bot commented Aug 5, 2025

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 634b797 v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

@potiuk
Copy link
Member

potiuk commented Aug 5, 2025

Hard to cherry-pick that one. I guess (unless we want to cherry-pick some other changes before) we should leave ot for 3.1 ? WDYT?

HsiuChuanHsu pushed a commit to HsiuChuanHsu/airflow that referenced this pull request Aug 5, 2025
* fix numpy serialization order of ops

* updating order to respect tuple and pydantic serialization
@astro-anand
Copy link
Contributor Author

@potiuk I am ok either way. @amoghrajesh what do you think? Happy to try to manually resolve the conflicts if needed

@potiuk
Copy link
Member

potiuk commented Aug 6, 2025

@potiuk I am ok either way. @amoghrajesh what do you think? Happy to try to manually resolve the conflicts if needed

I think you can try :) - but likely you should first try to find the previous commit that has not been cherry-picked for serialization and apply this first (and then yours) that might be way easier to apply in general).

ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 7, 2025
* fix numpy serialization order of ops

* updating order to respect tuple and pydantic serialization
fweilun pushed a commit to fweilun/airflow that referenced this pull request Aug 11, 2025
* fix numpy serialization order of ops

* updating order to respect tuple and pydantic serialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:serialization backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serialization returns unserialized numpy value

3 participants