-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix serialization order of ops #54139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Nice! Let's see if CI agrees :) |
|
@potiuk looks like CI agrees 😌 |
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 634b797 v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
|
Hard to cherry-pick that one. I guess (unless we want to cherry-pick some other changes before) we should leave ot for 3.1 ? WDYT? |
* fix numpy serialization order of ops * updating order to respect tuple and pydantic serialization
|
@potiuk I am ok either way. @amoghrajesh what do you think? Happy to try to manually resolve the conflicts if needed |
I think you can try :) - but likely you should first try to find the previous commit that has not been cherry-picked for serialization and apply this first (and then yours) that might be way easier to apply in general). |
* fix numpy serialization order of ops * updating order to respect tuple and pydantic serialization
* fix numpy serialization order of ops * updating order to respect tuple and pydantic serialization
Adjusted order of operations to run custom serialization first before checking if subclass of base object
closes: #54097
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.