fix(http): Fix HttpHook.url_from_endpoint() lazy initialization #54202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HsiuChuanHsu
force-pushed
the
bug/http-hook-url-from-endpoint-fix
branch
from
24ae4d6 to
1b9ac42
Compare
- Add _base_url_initialized flag to track initialization state - Implement lazy initialization in url_from_endpoint() method - Fix issue where url_from_endpoint() returns incorrect URL when called independently
HsiuChuanHsu
force-pushed
the
bug/http-hook-url-from-endpoint-fix
branch
from
1b9ac42 to
eb68093
Compare
potiuk
approved these changes
Aug 19, 2025
Member
|
Nice |
Contributor
Author
|
Thanks for the review! |
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
…he#54202) * fix(http): fix HttpHook.url_from_endpoint() without get_conn() call - Add _base_url_initialized flag to track initialization state - Implement lazy initialization in url_from_endpoint() method - Fix issue where url_from_endpoint() returns incorrect URL when called independently * Add modification on url_from_endpoint to make sure base_url is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
url_from_endpoint()returns incorrect relative path without calling get_conn() first, due to flawed lazy initializationCause
Logic used if not
self.base_urlfor initialization, but empty strings evaluate to False, triggering incorrect behaviorSolution:
_base_url_initializedboolean flag to track initialization_set_base_url()to set the flagurl_from_endpoint()to use flag for lazy initialization checkCloses: #54112
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.