Skip to content

Conversation

@vatsrahul1001
Copy link
Contributor

@vatsrahul1001 vatsrahul1001 commented Aug 7, 2025

closes: #53055 #53050

Testing
UI:
image

Filter by User
image

Filter by DAG_ID
image

Filter by Task ID
image
Filter by RUN_ID
image

Filter by Event Type
image

Filter by Dates
image

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:translations area:UI Related to UI/UX. For Frontend Developers. translation:default labels Aug 7, 2025
@vatsrahul1001 vatsrahul1001 marked this pull request as draft August 7, 2025 06:52
@vatsrahul1001 vatsrahul1001 changed the title Add filtering support to Audit Log view in Airflow UI Add filtering support to Audit Log view Aug 7, 2025
@vatsrahul1001 vatsrahul1001 marked this pull request as ready for review August 7, 2025 06:59
Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Functional but there are a few things to improve before we can merge.

@pierrejeambrun
Copy link
Member

We also need lables on the datetime fields, like this:

Screenshot 2025-08-11 at 12 38 10

Or it's impossible to know what the input is for.

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for dag_id you are filtering on dag_id, but what we actually show in the UI is the dag_display_name. We need to filter on dag_display_name so there is no inconsistency between what is displayed to the user in the table and what the filter is operating on. Similarly to #54049, it should also probably be a search, i.e use the seach bar and use a pattern on the dag_display_name.

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. A few more comments.

Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a follow up PR, I wonder if we would want to move the search boxes into the table header to save space and keep a better association of what you're searching:

https://tanstack.com/table/latest/docs/framework/react/examples/filters-fuzzy
Screenshot 2025-08-12 at 12 16 38 PM

@bbovenzi
Copy link
Contributor

For a follow up PR, I wonder if we would want to move the search boxes into the table header to save space and keep a better association of what you're searching:

https://tanstack.com/table/latest/docs/framework/react/examples/filters-fuzzy Screenshot 2025-08-12 at 12 16 38 PM

Actually, scratch this idea. We'll probably move them into an "Advanced Search" dropdown like originally planned

@bbovenzi bbovenzi added this to the Airflow 3.1.0 milestone Aug 14, 2025
@vatsrahul1001 vatsrahul1001 requested a review from bbovenzi August 18, 2025 07:13
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a few more comments to clean up the code

@vatsrahul1001 vatsrahul1001 requested a review from bbovenzi August 18, 2025 18:55
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@bbovenzi bbovenzi merged commit 5d6b943 into apache:main Aug 18, 2025
53 checks passed
@bbovenzi bbovenzi deleted the filters-audit-logs branch August 18, 2025 19:18
mangal-vairalkar pushed a commit to mangal-vairalkar/airflow that referenced this pull request Aug 30, 2025
* Add filtering support to Audit Log view in Airflow UI

* Fix lincense

* change event type from dropdown to text search

* implement review comments

* implement review comments

* implement review comments

* reuse reset filter

* implement review comments

* remove partial search from ui
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:translations area:UI Related to UI/UX. For Frontend Developers. translation:default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Filters] Add filters to Browse - Audit Log

4 participants