-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add filtering support to Audit Log view #54210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
airflow-core/src/airflow/ui/src/pages/Events/eventTypeOptions.ts
Outdated
Show resolved
Hide resolved
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Functional but there are a few things to improve before we can merge.
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also for dag_id you are filtering on dag_id, but what we actually show in the UI is the dag_display_name. We need to filter on dag_display_name so there is no inconsistency between what is displayed to the user in the table and what the filter is operating on. Similarly to #54049, it should also probably be a search, i.e use the seach bar and use a pattern on the dag_display_name.
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. A few more comments.
bbovenzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a follow up PR, I wonder if we would want to move the search boxes into the table header to save space and keep a better association of what you're searching:
https://tanstack.com/table/latest/docs/framework/react/examples/filters-fuzzy

Actually, scratch this idea. We'll probably move them into an "Advanced Search" dropdown like originally planned |
bbovenzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Just a few more comments to clean up the code
bbovenzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
* Add filtering support to Audit Log view in Airflow UI * Fix lincense * change event type from dropdown to text search * implement review comments * implement review comments * implement review comments * reuse reset filter * implement review comments * remove partial search from ui


closes: #53055 #53050
Testing

UI:
Filter by User

Filter by DAG_ID

Filter by Task ID


Filter by RUN_ID
Filter by Event Type

Filter by Dates

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.