Add template_searchpath Support via Config for DAG Rendering (#53792) #54256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nataneljpwd
suggested changes
Aug 10, 2025
Contributor
Nataneljpwd
left a comment
Nataneljpwd
left a comment
There was a problem hiding this comment.
Looks good!
Great job!
Only 1 comment that needs to be resolved and its perfect
Brunda10
force-pushed
the
template-path-config
branch
from
d949b2d to
34972df
Compare
potiuk
reviewed
Aug 14, 2025
Contributor
Author
|
Removed hardcoded default value |
eladkal
reviewed
Aug 19, 2025
uranusjr
reviewed
Aug 21, 2025
Member
|
This needs a test. |
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Member
+1 |
Contributor
Author
Added unit tests to verify template_searchpath behavior with both single and multiple paths configured. |
Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
uranusjr
reviewed
Sep 1, 2025
uranusjr
reviewed
Sep 1, 2025
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Contributor
Author
|
Hi @uranusjr, I’ve updated the PR with the changes based on your feedback. Could you kindly review it again and let me know if anything else? |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
template_searchpathas a documented config option inconfig_templates/config.ymlThis was suggested in #53972 as a more scalable approach instead of adding more CLI args or making it per-DAG. This PR implements that feedback .
Closes #53972