Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Aug 8, 2025

Change Summary:

  • Use GitHub search API to batch-fetch PRs by status (merged/closed/open)
  • Implement batch git operations replacing individual PR lookups
  • Add caching for commit SHAs and cherry-pick detection
  • Improve output clarity: rename 'MERGED' column to 'CHERRY'

Performance improvements:

  • --unmerged mode: 73s → 2.9s (96% faster)
  • Regular mode: 73s → 12.7s (83% faster)
  • Eliminates O(n) git operations with O(1) cache lookups

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

**Change Summary**:
- Use GitHub search API to batch-fetch PRs by status (merged/closed/open)
- Implement batch git operations replacing individual PR lookups
- Add caching for commit SHAs and cherry-pick detection
- Improve output clarity: rename 'MERGED' column to 'CHERRY'

**Performance improvements**:
- `--unmerged` mode: 73s → 2.9s (96% faster)
- Regular mode: 73s → 12.7s (83% faster)
- Eliminates O(n) git operations with O(1) cache lookups
@kaxil kaxil requested a review from amoghrajesh as a code owner August 8, 2025 21:39
@boring-cyborg boring-cyborg bot added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Aug 8, 2025
Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kaxil kaxil merged commit ffb9084 into apache:main Aug 8, 2025
54 checks passed
@kaxil kaxil deleted the more-improvement-dev- branch August 8, 2025 22:12
github-actions bot pushed a commit that referenced this pull request Aug 8, 2025
… faster) (#54292)

**Change Summary**:
- Use GitHub search API to batch-fetch PRs by status (merged/closed/open)
- Implement batch git operations replacing individual PR lookups
- Add caching for commit SHAs and cherry-pick detection
- Improve output clarity: rename 'MERGED' column to 'CHERRY'

**Performance improvements**:
- `--unmerged` mode: 73s → 2.9s (96% faster)
- Regular mode: 73s → 12.7s (83% faster)
- Eliminates O(n) git operations with O(1) cache lookups
(cherry picked from commit ffb9084)

Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
@github-actions
Copy link

github-actions bot commented Aug 8, 2025

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

kaxil added a commit that referenced this pull request Aug 8, 2025
… faster) (#54292) (#54293)

**Change Summary**:
- Use GitHub search API to batch-fetch PRs by status (merged/closed/open)
- Implement batch git operations replacing individual PR lookups
- Add caching for commit SHAs and cherry-pick detection
- Improve output clarity: rename 'MERGED' column to 'CHERRY'

**Performance improvements**:
- `--unmerged` mode: 73s → 2.9s (96% faster)
- Regular mode: 73s → 12.7s (83% faster)
- Eliminates O(n) git operations with O(1) cache lookups
(cherry picked from commit ffb9084)

Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
kaxil added a commit to astronomer/airflow that referenced this pull request Aug 8, 2025
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants